Issue 45345: Optimize default DB connection pool config#304
Merged
labkey-jeckels merged 2 commits intodevelopfrom Aug 24, 2022
Merged
Issue 45345: Optimize default DB connection pool config#304labkey-jeckels merged 2 commits intodevelopfrom
labkey-jeckels merged 2 commits intodevelopfrom
Conversation
labkey-jeckels
requested review from
labkey-adam,
labkey-jony,
labkey-stuartm and
labkey-willm
|
#https://github.com/LabKey/syseng-chef-server/pull/400 |
labkey-adam
approved these changes
Aug 18, 2022
Contributor
|
Are the [FATAL: database "bt3" does not exist] bootstrap errors related to your changes? |
labkey-stuartm
approved these changes
Aug 18, 2022
Contributor
Author
|
@labkey-adam yes, turns out that specifying an initialSize causes the connection pool to throw a SQLException when initializing due to the lack of a DB, breaking bootstrapping. I've backed out that part of the change, which was less important than the other edits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Reviewing performance data, we're spending a surprising amount of time validating DB connections before using them.
Changes